fix(svm): pin rust toolchain for solana #960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Reinis Martinsons <[email protected]>
Signed-off-by: Reinis Martinsons <[email protected]>
Signed-off-by: Reinis Martinsons <[email protected]>
Signed-off-by: Reinis Martinsons <[email protected]>
Reinis-FRP
requested review from
bmzig,
mrice32,
nicholaspai and
pxrl
as code owners
md0x
approved these changes
Apr 17, 2025
Reinis-FRP
added a commit
that referenced
this pull request
Apr 17, 2025
* fix(svm): pin rust toolchain for solana Signed-off-by: Reinis Martinsons <[email protected]> * fix: add local toolchain Signed-off-by: Reinis Martinsons <[email protected]> * fix: add rustfmt to nightly Signed-off-by: Reinis Martinsons <[email protected]> * fix: pin nightly in lint scripts Signed-off-by: Reinis Martinsons <[email protected]> --------- Signed-off-by: Reinis Martinsons <[email protected]>
Reinis-FRP
added a commit
that referenced
this pull request
Apr 17, 2025
* fix(svm): pin rust toolchain for solana Signed-off-by: Reinis Martinsons <[email protected]> * fix: add local toolchain Signed-off-by: Reinis Martinsons <[email protected]> * fix: add rustfmt to nightly Signed-off-by: Reinis Martinsons <[email protected]> * fix: pin nightly in lint scripts Signed-off-by: Reinis Martinsons <[email protected]> --------- Signed-off-by: Reinis Martinsons <[email protected]>
Reinis-FRP
added a commit
that referenced
this pull request
Apr 17, 2025
* fix(svm): pin rust toolchain for solana Signed-off-by: Reinis Martinsons <[email protected]> * fix: add local toolchain Signed-off-by: Reinis Martinsons <[email protected]> * fix: add rustfmt to nightly Signed-off-by: Reinis Martinsons <[email protected]> * fix: pin nightly in lint scripts Signed-off-by: Reinis Martinsons <[email protected]> --------- Signed-off-by: Reinis Martinsons <[email protected]>
Reinis-FRP
added a commit
that referenced
this pull request
Apr 18, 2025
* fix(svm): pin rust toolchain for solana * fix: add local toolchain * fix: add rustfmt to nightly * fix: pin nightly in lint scripts --------- Signed-off-by: Reinis Martinsons <[email protected]>
pxrl
pushed a commit
that referenced
this pull request
Apr 22, 2025
* fix(svm): pin rust toolchain for solana Signed-off-by: Reinis Martinsons <[email protected]> * fix: add local toolchain Signed-off-by: Reinis Martinsons <[email protected]> * fix: add rustfmt to nightly Signed-off-by: Reinis Martinsons <[email protected]> * fix: pin nightly in lint scripts Signed-off-by: Reinis Martinsons <[email protected]> --------- Signed-off-by: Reinis Martinsons <[email protected]>
md0x
pushed a commit
that referenced
this pull request
Apr 23, 2025
* fix(svm): pin rust toolchain for solana Signed-off-by: Reinis Martinsons <[email protected]> * fix: add local toolchain Signed-off-by: Reinis Martinsons <[email protected]> * fix: add rustfmt to nightly Signed-off-by: Reinis Martinsons <[email protected]> * fix: pin nightly in lint scripts Signed-off-by: Reinis Martinsons <[email protected]> --------- Signed-off-by: Reinis Martinsons <[email protected]>
md0x
added a commit
that referenced
this pull request
Apr 23, 2025
…t Instead of Signer (#971) * fix(svm): M-01 Deposit Tokens Transfers Signed-off-by: Pablo Maldonado <[email protected]> * feat: use unchecked account Signed-off-by: Pablo Maldonado <[email protected]> * feat: remove system acc Signed-off-by: Pablo Maldonado <[email protected]> * fix: deposit tests Signed-off-by: Pablo Maldonado <[email protected]> * fix: fill tests Signed-off-by: Pablo Maldonado <[email protected]> * refactor: rename and comments Signed-off-by: Pablo Maldonado <[email protected]> * fix: across plus Signed-off-by: Pablo Maldonado <[email protected]> * fix(svm): pin rust toolchain for solana (#960) * fix(svm): pin rust toolchain for solana Signed-off-by: Reinis Martinsons <[email protected]> * fix: add local toolchain Signed-off-by: Reinis Martinsons <[email protected]> * fix: add rustfmt to nightly Signed-off-by: Reinis Martinsons <[email protected]> * fix: pin nightly in lint scripts Signed-off-by: Reinis Martinsons <[email protected]> --------- Signed-off-by: Reinis Martinsons <[email protected]> * refactor: rename and organize function Signed-off-by: Pablo Maldonado <[email protected]> * feat: update deposit delegate seed Signed-off-by: Pablo Maldonado <[email protected]> * feat: use relay_hash from function arguments Signed-off-by: Pablo Maldonado <[email protected]> * fix: heap memory error Signed-off-by: Pablo Maldonado <[email protected]> * fix Signed-off-by: Pablo Maldonado <[email protected]> * refactor: cleanup Signed-off-by: Pablo Maldonado <[email protected]> * fix: deposit checks Signed-off-by: Pablo Maldonado <[email protected]> * fix: fill tests Signed-off-by: Pablo Maldonado <[email protected]> * fix: fill relay delagate Signed-off-by: Pablo Maldonado <[email protected]> * fix: fill Signed-off-by: Pablo Maldonado <[email protected]> * refactor: simplify Signed-off-by: Pablo Maldonado <[email protected]> * refactor: cleanup Signed-off-by: Pablo Maldonado <[email protected]> * test: update fill tests Signed-off-by: Pablo Maldonado <[email protected]> * refactor: comments Signed-off-by: Pablo Maldonado <[email protected]> * fix: scripts Signed-off-by: Pablo Maldonado <[email protected]> * refactor: make seed structs private Signed-off-by: Pablo Maldonado <[email protected]> * feat: add missing params to deposit hashes Signed-off-by: Pablo Maldonado <[email protected]> * refactor: simplify Signed-off-by: Pablo Maldonado <[email protected]> * refactor: delegate utils Signed-off-by: Pablo Maldonado <[email protected]> * refactor: anchor serialize Signed-off-by: Pablo Maldonado <[email protected]> * refactor: reuse helper deriveSeedHash Signed-off-by: Pablo Maldonado <[email protected]> * fix: move paused fills check in handler Signed-off-by: Reinis Martinsons <[email protected]> * feat: improvements Signed-off-by: Pablo Maldonado <[email protected]> * fix: remove program_id from transfer_from params Signed-off-by: Reinis Martinsons <[email protected]> * fix: fill import Signed-off-by: Pablo Maldonado <[email protected]> * fix: tests Signed-off-by: Pablo Maldonado <[email protected]> --------- Signed-off-by: Pablo Maldonado <[email protected]> Signed-off-by: Reinis Martinsons <[email protected]> Signed-off-by: Pablo Maldonado <[email protected]> Co-authored-by: Reinis Martinsons <[email protected]> Co-authored-by: Reinis Martinsons <[email protected]>
Reinis-FRP
added a commit
that referenced
this pull request
Apr 23, 2025
* fix(svm): L-01 create new vault on deposit if needed Signed-off-by: Reinis Martinsons <[email protected]> * fix: use stable toolchain in ci Signed-off-by: Reinis Martinsons <[email protected]> * fix(svm): pin rust toolchain for solana (#960) * fix(svm): pin rust toolchain for solana Signed-off-by: Reinis Martinsons <[email protected]> * fix: add local toolchain Signed-off-by: Reinis Martinsons <[email protected]> * fix: add rustfmt to nightly Signed-off-by: Reinis Martinsons <[email protected]> * fix: pin nightly in lint scripts Signed-off-by: Reinis Martinsons <[email protected]> --------- Signed-off-by: Reinis Martinsons <[email protected]> --------- Signed-off-by: Reinis Martinsons <[email protected]>
Reinis-FRP
added a commit
that referenced
this pull request
Apr 23, 2025
…raint (#962) * fix(svm): pin rust toolchain for solana (#960) * fix(svm): pin rust toolchain for solana Signed-off-by: Reinis Martinsons <[email protected]> * fix: add local toolchain Signed-off-by: Reinis Martinsons <[email protected]> * fix: add rustfmt to nightly Signed-off-by: Reinis Martinsons <[email protected]> * fix: pin nightly in lint scripts Signed-off-by: Reinis Martinsons <[email protected]> --------- Signed-off-by: Reinis Martinsons <[email protected]> * fix(svm): N-03 use consistent variable names in the instruction constraint Signed-off-by: Reinis Martinsons <[email protected]> * fix: restore relay_hash naming in FillRelay context Signed-off-by: Reinis Martinsons <[email protected]> --------- Signed-off-by: Reinis Martinsons <[email protected]>
pxrl
pushed a commit
that referenced
this pull request
Apr 25, 2025
* fix(svm): pin rust toolchain for solana Signed-off-by: Reinis Martinsons <[email protected]> * fix: add local toolchain Signed-off-by: Reinis Martinsons <[email protected]> * fix: add rustfmt to nightly Signed-off-by: Reinis Martinsons <[email protected]> * fix: pin nightly in lint scripts Signed-off-by: Reinis Martinsons <[email protected]> --------- Signed-off-by: Reinis Martinsons <[email protected]>
Reinis-FRP
added a commit
that referenced
this pull request
May 21, 2025
* feat(svm): remove enabled deposit route check (#939) * feat(svm): remove enabled deposit route check Signed-off-by: Reinis Martinsons <[email protected]> * fix: remove create_vault ix Signed-off-by: Reinis Martinsons <[email protected]> * Update scripts/svm/simpleDeposit.ts Co-authored-by: Chris Maree <[email protected]> * fix: update comment Signed-off-by: Reinis Martinsons <[email protected]> --------- Signed-off-by: Reinis Martinsons <[email protected]> Co-authored-by: Chris Maree <[email protected]> * feat(svm): test native sol deposits (#942) * feat(svm): test native sol deposits Signed-off-by: Reinis Martinsons <[email protected]> * fix: merge issues Signed-off-by: Reinis Martinsons <[email protected]> --------- Signed-off-by: Reinis Martinsons <[email protected]> * fix(svm): pin rust toolchain for solana (#960) (#961) * fix(svm): pin rust toolchain for solana * fix: add local toolchain * fix: add rustfmt to nightly * fix: pin nightly in lint scripts --------- Signed-off-by: Reinis Martinsons <[email protected]> * fix(svm): M-01 Deposit Tokens Transferred from Depositor Token Account Instead of Signer (#971) * fix(svm): M-01 Deposit Tokens Transfers Signed-off-by: Pablo Maldonado <[email protected]> * feat: use unchecked account Signed-off-by: Pablo Maldonado <[email protected]> * feat: remove system acc Signed-off-by: Pablo Maldonado <[email protected]> * fix: deposit tests Signed-off-by: Pablo Maldonado <[email protected]> * fix: fill tests Signed-off-by: Pablo Maldonado <[email protected]> * refactor: rename and comments Signed-off-by: Pablo Maldonado <[email protected]> * fix: across plus Signed-off-by: Pablo Maldonado <[email protected]> * fix(svm): pin rust toolchain for solana (#960) * fix(svm): pin rust toolchain for solana Signed-off-by: Reinis Martinsons <[email protected]> * fix: add local toolchain Signed-off-by: Reinis Martinsons <[email protected]> * fix: add rustfmt to nightly Signed-off-by: Reinis Martinsons <[email protected]> * fix: pin nightly in lint scripts Signed-off-by: Reinis Martinsons <[email protected]> --------- Signed-off-by: Reinis Martinsons <[email protected]> * refactor: rename and organize function Signed-off-by: Pablo Maldonado <[email protected]> * feat: update deposit delegate seed Signed-off-by: Pablo Maldonado <[email protected]> * feat: use relay_hash from function arguments Signed-off-by: Pablo Maldonado <[email protected]> * fix: heap memory error Signed-off-by: Pablo Maldonado <[email protected]> * fix Signed-off-by: Pablo Maldonado <[email protected]> * refactor: cleanup Signed-off-by: Pablo Maldonado <[email protected]> * fix: deposit checks Signed-off-by: Pablo Maldonado <[email protected]> * fix: fill tests Signed-off-by: Pablo Maldonado <[email protected]> * fix: fill relay delagate Signed-off-by: Pablo Maldonado <[email protected]> * fix: fill Signed-off-by: Pablo Maldonado <[email protected]> * refactor: simplify Signed-off-by: Pablo Maldonado <[email protected]> * refactor: cleanup Signed-off-by: Pablo Maldonado <[email protected]> * test: update fill tests Signed-off-by: Pablo Maldonado <[email protected]> * refactor: comments Signed-off-by: Pablo Maldonado <[email protected]> * fix: scripts Signed-off-by: Pablo Maldonado <[email protected]> * refactor: make seed structs private Signed-off-by: Pablo Maldonado <[email protected]> * feat: add missing params to deposit hashes Signed-off-by: Pablo Maldonado <[email protected]> * refactor: simplify Signed-off-by: Pablo Maldonado <[email protected]> * refactor: delegate utils Signed-off-by: Pablo Maldonado <[email protected]> * refactor: anchor serialize Signed-off-by: Pablo Maldonado <[email protected]> * refactor: reuse helper deriveSeedHash Signed-off-by: Pablo Maldonado <[email protected]> * fix: move paused fills check in handler Signed-off-by: Reinis Martinsons <[email protected]> * feat: improvements Signed-off-by: Pablo Maldonado <[email protected]> * fix: remove program_id from transfer_from params Signed-off-by: Reinis Martinsons <[email protected]> * fix: fill import Signed-off-by: Pablo Maldonado <[email protected]> * fix: tests Signed-off-by: Pablo Maldonado <[email protected]> --------- Signed-off-by: Pablo Maldonado <[email protected]> Signed-off-by: Reinis Martinsons <[email protected]> Signed-off-by: Pablo Maldonado <[email protected]> Co-authored-by: Reinis Martinsons <[email protected]> Co-authored-by: Reinis Martinsons <[email protected]> * fix(svm): N-01 remove v3 from remaining functions and comments (#964) Signed-off-by: Reinis Martinsons <[email protected]> * fix(svm): L-01 create new vault on deposit if needed (#957) * fix(svm): L-01 create new vault on deposit if needed Signed-off-by: Reinis Martinsons <[email protected]> * fix: use stable toolchain in ci Signed-off-by: Reinis Martinsons <[email protected]> * fix(svm): pin rust toolchain for solana (#960) * fix(svm): pin rust toolchain for solana Signed-off-by: Reinis Martinsons <[email protected]> * fix: add local toolchain Signed-off-by: Reinis Martinsons <[email protected]> * fix: add rustfmt to nightly Signed-off-by: Reinis Martinsons <[email protected]> * fix: pin nightly in lint scripts Signed-off-by: Reinis Martinsons <[email protected]> --------- Signed-off-by: Reinis Martinsons <[email protected]> --------- Signed-off-by: Reinis Martinsons <[email protected]> * fix(svm): N-02 clarify documentation (#963) Signed-off-by: Reinis Martinsons <[email protected]> * fix(svm): N-03 use consistent variable names in the instruction constraint (#962) * fix(svm): pin rust toolchain for solana (#960) * fix(svm): pin rust toolchain for solana Signed-off-by: Reinis Martinsons <[email protected]> * fix: add local toolchain Signed-off-by: Reinis Martinsons <[email protected]> * fix: add rustfmt to nightly Signed-off-by: Reinis Martinsons <[email protected]> * fix: pin nightly in lint scripts Signed-off-by: Reinis Martinsons <[email protected]> --------- Signed-off-by: Reinis Martinsons <[email protected]> * fix(svm): N-03 use consistent variable names in the instruction constraint Signed-off-by: Reinis Martinsons <[email protected]> * fix: restore relay_hash naming in FillRelay context Signed-off-by: Reinis Martinsons <[email protected]> --------- Signed-off-by: Reinis Martinsons <[email protected]> * feat: update toolchain Signed-off-by: Pablo Maldonado <[email protected]> * feat: update toolchain bis Signed-off-by: Pablo Maldonado <[email protected]> * fix: delete old scripts Signed-off-by: Pablo Maldonado <[email protected]> * fix: across plus codama test Signed-off-by: Pablo Maldonado <[email protected]> * fix: fill test codama Signed-off-by: Pablo Maldonado <[email protected]> * feat: bump version Signed-off-by: Pablo Maldonado <[email protected]> * fix: bump version Signed-off-by: Reinis Martinsons <[email protected]> --------- Signed-off-by: Reinis Martinsons <[email protected]> Signed-off-by: Pablo Maldonado <[email protected]> Signed-off-by: Pablo Maldonado <[email protected]> Co-authored-by: Reinis Martinsons <[email protected]> Co-authored-by: Chris Maree <[email protected]> Co-authored-by: Reinis Martinsons <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
anchor-synhas been using an unstable API fromproc-macro2where a recent release introduced a breaking change. Since Anchor IDL generation depends on nightly, we need to pin it to known working version. The issue has been reported here.The fix also creates wrapper scripts around anchor build and test commands, so that it uses the pinned nightly toolchain.
Anchor is fixing the issue here, once that is merged and released, we could try to revert this workaround and update to the latest anchor release.